Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to update a point cloud #3468

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

voigta
Copy link
Contributor

@voigta voigta commented Aug 9, 2024

This PR adds a function to PointCloud which allows to update the point positions and colors.

@falkoschindler falkoschindler self-requested a review August 9, 2024 16:32
@falkoschindler falkoschindler added the enhancement New feature or request label Aug 9, 2024
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @voigta!

  • I just made sure to reuse the existing geometry object. But I'm not sure if this is relevant for performance or memory.
  • And I updated the example to make it a bit more interactive while keeping it as simple as possible.

Let's merge! 🚀

@falkoschindler falkoschindler added this to the 1.4.35 milestone Aug 12, 2024
@falkoschindler falkoschindler merged commit 245c202 into zauberzeug:main Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants