Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct version for citation file #3587

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Use correct version for citation file #3587

merged 1 commit into from
Aug 25, 2024

Conversation

falkoschindler
Copy link
Contributor

I noticed that our CITATION.cff file is always one version behind. Therefore this PR uses the same GITHUB_REF like we use for updating the pyproject file.

By the way, I wonder if

$(echo ${GITHUB_REF/refs\/tags\//})

could be simplified to

${GITHUB_REF/refs\/tags\//}

But I don't feel like risking a messed up release.

@falkoschindler falkoschindler added the enhancement New feature or request label Aug 24, 2024
@falkoschindler falkoschindler added this to the 1.4.37 milestone Aug 24, 2024
@rodja rodja merged commit 98ab19f into main Aug 25, 2024
7 checks passed
@rodja rodja deleted the citation branch August 25, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants