Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disableable elements #797

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Disableable elements #797

merged 5 commits into from
Apr 20, 2023

Conversation

falkoschindler
Copy link
Contributor

Originating from discussion #560 I implemented "disableable elements".

@falkoschindler falkoschindler added this to the v1.2.9 milestone Apr 19, 2023
rodja
rodja approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@rodja rodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@falkoschindler
Copy link
Contributor Author

Before merging into main, I think I'll make enabled a bindable property.
And even though we don't need to test enabling/disabling all elements, adding a pytest for, e.g., disabling a button would be nice.

@falkoschindler falkoschindler marked this pull request as ready for review April 20, 2023 07:17
@falkoschindler falkoschindler self-assigned this Apr 20, 2023
@falkoschindler falkoschindler merged commit fe1eaab into main Apr 20, 2023
@falkoschindler falkoschindler deleted the disableable branch April 20, 2023 09:54
falkoschindler added a commit that referenced this pull request Apr 27, 2023
@falkoschindler
#797 add binding methods for disableable elements
59099b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodja rodja rodja approved these changes

Assignees

@falkoschindler falkoschindler

Labels
None yet
Projects
None yet
Milestone
v1.2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@falkoschindler @rodja