Use snake_case style arguments for ui.notify() #930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @rodja's comment in #928 as a potential change for 1.3...
Draft pull request to change arguments in
notify.py
to use snake_case style names (and convert to Quasar option names where appropriate).Also added
multi_line
as an argument since there is a specific example for multi-line notifications in the documentation, renamed the**kwargs
argument to**_kwargs
so it is excluded fromoptions
(just for clarity), and updated documentation to new argument names.Not sure if this is the best approach, just putting it out there for consideration.