Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web Audio support #20

Merged
merged 18 commits into from
Mar 12, 2015
Merged

Add Web Audio support #20

merged 18 commits into from
Mar 12, 2015

Conversation

geloescht
Copy link
Contributor

This branch adds support for audio nodes by providing a thin layer over the Web Audio API that is implemented in modern Firefox and Webkit browsers. These nodes currently do not support spreading.

@ghost
Copy link

ghost commented Mar 8, 2015

Excellent news :)

On 8 March 2015 at 18:16, geloescht notifications@github.com wrote:

This branch adds support for audio nodes by providing a thin layer over
the Web Audio API that is implemented in modern Firefox and Webkit

browsers. These nodes currently do not support spreading.

You can view, comment on, or merge this pull request online at:

#20
Commit Summary

  • First implementation of WebAudio nodes
  • Fix typ in audio code and WebAudio not working in Firefox when muted
  • Fix connecting and deconnecting of Web Audio nodes
  • Fix audio nodes not updating in cascade
  • Add AudioDestination (HTML5 Audio)
  • Web Audio: fix param pins not implemented properly
  • Add Oscillator (HTML5 Audio)
  • Add Delay (HTML5 Audio)
  • Add Gain (HTML5 Audio)
  • Add DynamicsCompressor (HTML5 Audio)
  • Add BiquadFilter (HTML5 Audio)
  • Add FileAudioBuffer (HTML5 Audio)
  • Add Convolver (HTML5 Audio)
  • Import beatdetektor in as node requirement instead of directly in
    vvvv.js
  • Merge: pull newest upstream master
  • Fix missing VVVV. prefix

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#20.

zauner added a commit that referenced this pull request Mar 12, 2015
@zauner zauner merged commit 56b51d3 into zauner:master Mar 12, 2015
@zauner
Copy link
Owner

zauner commented Mar 12, 2015

Well that's indeed excellent news. Also: great job with the clever implementation!

Funny/tragic coinsidence is, that @artofmus from this forum thread just finished a first draft of his version of a WebAudio implementation, when we discovered the pull request. I think it would be great if @artofmus joined the discussion, and if we joined forces for future improvements.

Regarding the audio param pins, which should also be connected to audio signals: I think we need a special pin type VVVV.PinTypes.AudioParam for this. It should work as a value pin in the editor, but should also accept incoming audio signals. I will need to have a look into this, as VVVV.js at the moment does not support subtypes, as VVVV does.

@geloescht
Copy link
Contributor Author

Thanks for the pull! :)
As for @artofmus's implementation, I was not aware of that. I wasn't even aware of the whole vvvv.js forum. Well, I am looking forward to a collaboration!
Here are the few loose ends I think should be tied before we call this implementation final:

  1. The AudioParam issue. Can input pins support multiple data types?
  2. Spreading. Should we create multiple API nodes inside a VVVV.js node when we have multiple input slices? When should we downmix spreaded audio streams?
  3. Mixing. Right now there is no Mixer node because there is no 1:1 mapping to a Web Audio node. I'd like to take a look at VAudio before tackling this.

@zauner
Copy link
Owner

zauner commented Mar 13, 2015

Yes, these were the 3 points we also identified. As each of these are quite complex i opened separate issues for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants