-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update transcript list #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniqueg
approved these changes
Oct 3, 2024
If you think a fix will come within the next few days, then wait - otherwise pin. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #168 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1143 1142 -1
=========================================
- Hits 1143 1142 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
transcripts.fasta.gz
to include transcript sequences from an updated set of small subunit RP genes (RPSA, RPS2, RPS3, RPS9, RPS11, RPS13, RPS14, RPS15, RPS15A, RPS16, RPS18, RPS20, RPS23, RPS29) that are consistent across the domains of Bacteria, Archaea and Eukaryotes (so in the future Bacteria can also be included). The RP genes were selected based on https://bangroup.ethz.ch/research/nomenclature-of-ribosomal-proteins.html. Human genes and their orthologs were downloaded from Ensembl main (Vertebrates), Ensembl Plants, Ensembl Fungi and Ensembl Metazoa. The set now consists of 14410 transcripts from 385 organisms.v0.11.0
too-many-positional-arguments
inget_read_layout.py
(related to changes in pylint v3.3)Closes #108
Closes #56
Type of change
Please delete options that are not relevant.
Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes
If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.