Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read orientation #73

Merged
merged 18 commits into from
May 17, 2022
Merged

feat: read orientation #73

merged 18 commits into from
May 17, 2022

Conversation

rohank63
Copy link
Collaborator

@rohank63 rohank63 commented Apr 6, 2021

Description

  • implement functionality to infer read orientation for single- and paired-ended libraries
  • most unit tests for new functionality missing

Fixes #67

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • Documentation update

Checklist

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

@rohank63 rohank63 changed the title Orientation v2 feat: added orientation Apr 6, 2021
@rohank63 rohank63 changed the title feat: added orientation feat: read orientation Apr 6, 2021
@uniqueg uniqueg self-assigned this Mar 14, 2022
@uniqueg uniqueg self-requested a review March 14, 2022 00:25
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #73 (175689d) into dev_v2 (a762728) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            dev_v2       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          506       553   +47     
=========================================
+ Hits           506       553   +47     
Impacted Files Coverage Δ
htsinfer/__init__.py 100.00% <100.00%> (ø)
htsinfer/cli.py 100.00% <100.00%> (ø)
htsinfer/exceptions.py 100.00% <100.00%> (ø)
htsinfer/htsinfer.py 100.00% <100.00%> (ø)
htsinfer/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a762728...175689d. Read the comment docs.

@uniqueg uniqueg merged commit 051e4e4 into dev_v2 May 17, 2022
@uniqueg uniqueg deleted the orientation_v2 branch May 17, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle multimappers correctly
3 participants