Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiorganism support #172

Merged
merged 6 commits into from
Feb 21, 2024
Merged

feat: multiorganism support #172

merged 6 commits into from
Feb 21, 2024

Conversation

mkatsanto
Copy link
Collaborator

Description

ZARP was working only for same organism samples in the input folder.
To ensure multiorganism support we needed to

  • add one more level in the results sample architecture for each of the organisms
  • make sure aggregation rules (multiQC, summary tables, PCA) were applied for each organism
  • fix all samples paths in the tests

Fixes #171

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Conventional Commits guidelines

Changes to workflow inputs (sample table and/or configs)

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • more fields/properties are required
    • existing ones are dropped entirely
  • minor (add feat: in the beginning of the PR title)
    • optional fields/properties are added
    • required ones are made optional

Changes to workflow outputs

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • changes lead to removal/change of existing outputs (format or location)
  • minor (add feat: in the beginning of the PR title)
    • additional outputs are generated
    • content (but not format or location) of existing outputs changes

Everything else: patch
(add any other conventional commit in the beginning of the PR title)

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • [] I have updated the project's documentation

@github-actions github-actions bot added the enhancement New feature or request label Feb 20, 2024
@uniqueg uniqueg changed the title feat: Multiorganism support feat: multiorganism support Feb 20, 2024
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, what a change 🙈🙏
But I think this looks good! :)

@mkatsanto mkatsanto merged commit ac95347 into dev Feb 21, 2024
11 checks passed
@mkatsanto mkatsanto deleted the issue_171_multiorganism_support branch February 21, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-organism analysis
2 participants