changes to Chinese Codification #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrCartmenez
suggested changes
Sep 3, 2020
| @@ -35,7 +35,7 @@ class MbWrapper | |||
| public static $mbAliases = [ | |||
| // supported but not included in mb_list_encodings for some reason... | |||
| 'CP850' => 'CP850', | |||
| 'GB2312' => 'GB2312', | |||
| 'GB2312' => 'GB18030', | |||
There was a problem hiding this comment.
This change provides a supported encoding, so can move down in the list.
|
GB18030 is supported in PHP and backwards compatible with GB2312. |
|
Sorry, didn't notice your pull request before today. Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes repair problems with some characters in GB2312 codification using GB18030.