Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Psr\Http\Message\StreamInterface spec #15

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Apr 19, 2023

New Psr\Http\Message\StreamInterface breaks the code. Apparently this broke 2023-04-18 for my PHPFUI site which updates nightly. I suspect it was caused by a GuzzleHttp dependency that finally allowed my site to be upgraded to the latest StreamInterface.

The issue is now PHP 7.1 is broken. But at this point I think it is worth dropping 7.1 support. There is absolutely no reason for anyone to be on 7.1, or they can lock in an old version.

I did not include that in the PR, but happy to do so.

@zbateson zbateson merged commit 712b9e7 into zbateson:master Apr 19, 2023
12 checks passed
@zbateson
Copy link
Owner

Wonderful, thank you!

@phpfui
Copy link
Contributor Author

phpfui commented Apr 19, 2023

Release and rerun the tests on the other two packages to make sure they are now compatible. If not, I can drop 7.1 support on them. Let me know.

@zbateson
Copy link
Owner

Seems to be all good locally for me at least -- I can't seem to find a way to rerun tests on github without adding a commit, but testing locally on 7.1 worked, as did later versions which included this update.

@phpfui
Copy link
Contributor Author

phpfui commented Apr 19, 2023

OK, good. I can't test below 7.4 without a more advanced setup, but I don't support anything less than 8.0 at this point, so have not bothered with a better setup. At this point, I just drop old versions when they cause any grief. I dropped 8.0 for one of my packages recently for some reason. Not worth spending any time supporting old versions. It either works or is dropped. So much easier!

@phpfui phpfui deleted the PSRFixes branch August 17, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants