Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set predicted recall to zero for docs without predicted labels #4

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

cbartz
Copy link
Contributor

@cbartz cbartz commented Oct 4, 2022

It is currently (v.0.1.0) possible for a document with null predicted labels to receive a non-zero recall prediction from Qualle. By definition, for a document with null predicted labels, the recall can only be null. This PR fixes this by bypassing the predictor and directly nulling the recall for documents without predicted labels.

@cbartz cbartz requested a review from mo-fu October 4, 2022 13:26
@cbartz cbartz self-assigned this Oct 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Base: 93.43% // Head: 93.64% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (86c7690) compared to base (ed521ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   93.43%   93.64%   +0.21%     
==========================================
  Files          20       20              
  Lines         685      708      +23     
==========================================
+ Hits          640      663      +23     
  Misses         45       45              
Impacted Files Coverage Δ
qualle/evaluate.py 100.00% <ø> (ø)
qualle/features/base.py 100.00% <ø> (ø)
qualle/features/combined.py 100.00% <ø> (ø)
qualle/features/confidence.py 100.00% <ø> (ø)
qualle/features/label_calibration/base.py 100.00% <ø> (ø)
...ures/label_calibration/simple_label_calibration.py 100.00% <ø> (ø)
...es/label_calibration/thesauri_label_calibration.py 99.04% <ø> (ø)
qualle/features/text.py 100.00% <ø> (ø)
qualle/interface/cli.py 53.08% <ø> (ø)
qualle/interface/config.py 100.00% <ø> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbartz cbartz merged commit 34248b7 into master Oct 5, 2022
@cbartz cbartz deleted the zero-recall branch October 7, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants