Update to Mapillary V4 API

[kudlav]

I should point to the selected place but it's not reliable. Currently sometimes points to it, but sometimes it shows the opposite direction.

should fix: #97

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
osmapp	✅ Ready (Inspect)	Visit Preview	Oct 14, 2022 at 8:18PM (UTC)

[zbycz]

Wow, good job @kudlav! I will review it tomorrow :)

[kudlav]

Better than nothing, but the bearing function doesn't work properly. I've tried the best, tried different functions, but no success :(

osmapp/src/services/images/getMapillaryImage.ts

Lines 7 to 13 in 9c38d85

	const bearing = (a1: number, a2: number, b1: number, b2: number): number => {
	const rad2deg = 57.2957795130823209;
	if (a1 === b1 && a2 === b2) return Infinity;
	let theta = Math.atan2(b1 - a1, a2 - b2);
	if (theta < 0) theta += Math.PI * 2;
	return rad2deg * theta;
	};

The steps are:

• get an images near the location
• get the image that has the smallest deviation between picture compass angle and ideal angle of line from picture to the location

[zbycz]

So, I have managed to write some tests for the bearing function, and everything appears to be corect. I will continue with debuging the main function :)

[zbycz]

Hi @kudlav, so i think I have managed to fix the issue. There was only one issue, that you had Math.atan2(b1 - a1, a2 - b2) but it supposed to be Math.atan2(b1 - a1, b2 - a2). I wrote some unit tests to uncover this, but got confused what is right and wrong, so it took a little longer 😃

Also I refactored the code a little, so i could understand it more easily.

Right now, i left debugging output in place, because it helps understand which photo is chosen. The rotation of the marker is the compas_angle. Red marker is the closest one. Let me know if you found it working and we can remove this and merge it 🎉

eg.

[zbycz]

Hmm, strange. I have found few examples, where Mapillary returns photos which are out of requested BBOX.

Eg.

• poi 50.09812,14.40530
• request: 14.40489,50.09772,14.405690000000002,50.09852
• It shows images with LAT as far as 14.407301

I would like to know your point of view. Should we fill a bug report? Or maybe i am overlooking sth?

//edit: i tried replacing , with %2C as in here, and still wrong
//edit2: When i checked the real coverage of this area, the returned photos doesnt seem that wrong - a.k.a. there isnt any good photo anyway.

[zbycz]

So after a week i decided to merge this, we can update the algorithm if we found why is the Mapillary glitch happening. I would like your opinion on that.

I thought it would be good to have the debug info in place, so it can be switched on by adding debug_mapillary=true to localStorage.

Thanks for the great work! 👍 👍 ❤️