Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: add dark mode UI #137

Merged
merged 11 commits into from
Mar 22, 2023
Merged

App: add dark mode UI #137

merged 11 commits into from
Mar 22, 2023

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Feb 23, 2023

Preview URL: https://osmapp-git-darkmode-ui-zbycz.vercel.app/

TODO:

  • betatest (colors + the switcher)
  • add translations for picker

Known issue:

  • in auto mode + dark system theme, the page flickers on first load. The solution could be implemented later.

fixes #134

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osmapp ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 6:47PM (UTC)

@Flohhhhh
Copy link
Contributor

image
Icons in nearby do not change

@Flohhhhh
Copy link
Contributor

The colors could use some work but I'm not seeing any major issues! Looks good!

@zbycz
Copy link
Owner Author

zbycz commented Mar 22, 2023

Thanks for the test @Flohhhhh. I have fixed the icons and I am merging this PR now. We can finetune the colors later. Especially aweful is the red around the searchbox, but i guess it would look better when Map will be dark as well.

@zbycz zbycz merged commit 67625a4 into master Mar 22, 2023
@zbycz zbycz deleted the darkmode-ui branch March 22, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode
2 participants