Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchBox: add search by categories + overpass #186

Merged
merged 36 commits into from
Sep 30, 2023
Merged

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Sep 23, 2023

Categories taken from the id-tagging-schema project, the same as we already display above feature name. Works thanks to groundwork in #116.

Search is performed on overpass API, which is exceptionaly fast for such queries (<500ms).

TODO:

  • test services
  • limit number of beforeItems
  • enable search again (item cant be selected)
  • successbox translation

Followup issue: #191

image

@vercel
Copy link

vercel bot commented Sep 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Sep 30, 2023 4:25pm

@Dlurak
Copy link
Collaborator

Dlurak commented Sep 23, 2023

I've used it a bit and noticed one problem:
When you search for "Bus Route" the map will stay empty. I think this is because the overpass-query returns only relations.

But anyways a great addition, I can really see myself using it in my everyday live.

@zbycz
Copy link
Owner Author

zbycz commented Sep 24, 2023 via email

# Conflicts:
#	src/services/__tests__/osmApi.test.ts
@zbycz zbycz merged commit d7651e9 into master Sep 30, 2023
2 checks passed
@zbycz zbycz deleted the overpass-search branch September 30, 2023 16:30
@zbycz
Copy link
Owner Author

zbycz commented Sep 30, 2023

Hi @Dlurak - fyi - i deployed the current version without relations. I tried it, and its not that hard, but i wanted to leave it for a followup issue: #191 :)

@zbycz
Copy link
Owner Author

zbycz commented Dec 3, 2023

@Dlurak relations were done in #213, already deployed on osmapp.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants