Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: Update Dockerfile build node to version 20 #520

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Sep 7, 2024

Project was updated to node 20, this makes the Dockerimage compatible

  • we switch the image to a Debian based one, because some node binaries are not available directly for alpine and would need to be built

The docker image is currently not automatically build in this repo, we might add an action like this:

https://github.com/OpenPlaceGuide/osmapp/blob/opg-master/.github/workflows/docker-image.yml

But we can also leave it semi-supported in here and I will take care of it, when I spot problems.

* we switch the image to debian based, because some node binaries are not available directly for alpine and would need to be built
Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Sep 7, 2024 2:14pm

@zbycz zbycz changed the title Update Dockerfile build node to version 20 general: Update Dockerfile build node to version 20 Sep 8, 2024
@zbycz zbycz merged commit f7bf56f into zbycz:master Sep 8, 2024
2 checks passed
@zbycz
Copy link
Owner

zbycz commented Sep 8, 2024

Hi @amenk, thanks for the changes. Since we don't use docker for running OsmAPP production, I prefer not to run it on every commit to master.

If you can find some unobtrusive option, we can add it. Sth like running nightly + not showing up in the master branch checks, but only when you click the specific workflow in actions menu? Not sure if this is possible though 😄

@amenk amenk deleted the docker-node-20 branch September 8, 2024 11:09
@amenk
Copy link
Contributor Author

amenk commented Sep 8, 2024

All good - Let's leave it like this. We are irregularly rebasing onto OSM app and will check this way and provide a pull request if necessary.

@zbycz
Copy link
Owner

zbycz commented Sep 8, 2024

@amenk Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants