1.降低使用门槛，尤其是恼人的goproxy代理，2.支持Makefile 3.增加telegram文字通知 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢 Contribute！ |
zc2638
reviewed
Apr 17, 2022
Comment on lines
+3
to
+4
| token: "**09724:AAEW***KhR**" | ||
| chat_id: "89***381" |
There was a problem hiding this comment.
默认配置 建议留空，很多用户不会使用telegram，也不会修改这里的配置，将会在通知的时候报错。
如果需要example，可以在注释提示
| } | ||
|
|
||
| func NewTelegramBot(cf *TelegramBotConf) *TelegramBot { | ||
| return &TelegramBot{ |
There was a problem hiding this comment.
参考：https://github.com/zc2638/ddshop/blob/main/pkg/notice/notice.go#L32-L41
这里判断一下如果必要的配置不存在，返回一个 nil 用于不初始化 TelegramBot 实例，并且返回参数应该是 Engine Interface
Comment on lines
+6
to
+7
| content: "搞快点,速来叮咚买菜小程序付钱!" | ||
| title: "🔥我，秦始皇，打钱" |
There was a problem hiding this comment.
通知内容目前统一由代码层面处理，后续可以考虑统一抽出来。因为要作用于 所有通知服务
|
format无须添加make命令，可以增加 |
|
好的 我cancel了 sorry 我是自己使用怎么来 没太考虑friendly |
|
可以把 PR 稍微修改一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
telegram尚未经过测试 应该没啥问题 比较easy
其他都玩过 功能ok