Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to get authentication path to previous checkpoint #22

Closed
str4d opened this issue Mar 7, 2022 · 1 comment
Closed

Add ability to get authentication path to previous checkpoint #22

str4d opened this issue Mar 7, 2022 · 1 comment
Assignees
@nuttycom @daira
Labels
S-committed
Milestone
Release 5.0.0

Comments

@str4d
Copy link
Contributor

str4d commented Mar 7, 2022

In zcashd we want to be able to fetch the authentication path from a wallet note to an anchor that is not necessarily the most recent tree root. In incrementalmerkletree terms, that means we need to alter Tree::authentication_path to take a checkpoint_offset: usize parameter, where 0 means "no offset, use the latest tree state", and non-zero values mean "ignore the most recent checkpoint_offset checkpoint intervals" (i.e. give the equivalent path that we'd get if we called Tree::rewind checkpoint_offset times and then called Tree::authentication_path.
@str4d str4d mentioned this issue Mar 7, 2022
Closed
str4d added a commit to str4d/zcash that referenced this issue Mar 15, 2022
@str4d
Set default Orchard anchor confirmations to 1
381b626 
Currently we cannot use anything greater than 1, because the Orchard
witness tree cannot provide authentication paths to anything but the
current tree root. Once zcash/incrementalmerkletree#22 is implemented,
we can revert this change as part of zcash#5644.
@r3ld3v r3ld3v added this to the Release 5.0.0 milestone Mar 29, 2022
@nuttycom
Copy link
Contributor

Fixed by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuttycom nuttycom

@daira daira

Labels
S-committed
Projects
None yet
Milestone
Release 5.0.0
Development

No branches or pull requests
4 participants
@nuttycom @daira @str4d @r3ld3v