Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shardtree: Switch from Rc to Arc to make trees Send #86

Merged
merged 1 commit into from
Jul 17, 2023
Merged

shardtree: Switch from Rc to Arc to make trees Send #86

merged 1 commit into from
Jul 17, 2023

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jul 14, 2023

No description provided.

@str4d
Copy link
Contributor Author

str4d commented Jul 14, 2023

CI is failing for the same reason it did in #85. Fix is over there.

ebfull
ebfull approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ebfull ebfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK modulo a rebase and CI run

ebfull
ebfull approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ebfull ebfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK

@str4d str4d merged commit bae25ad into master Jul 17, 2023
@str4d str4d deleted the shardtree-arc-wielder branch July 17, 2023 22:01
daira
daira reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@ebfull ebfull ebfull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@str4d @daira @ebfull