Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to test the librustzcash FFI #57

Closed
str4d opened this issue Jan 15, 2019 · 1 comment
Closed

Decide how to test the librustzcash FFI #57

str4d opened this issue Jan 15, 2019 · 1 comment
Labels

Comments

@str4d
Copy link
Contributor

str4d commented Jan 15, 2019

Once #41 is completed, the librustzcash crate should just be an FFI wrapper around a set of pure-Rust APIs. Currently, we test (some of) this FFI indirectly via testing of zcashd. We should instead have FFI tests in the librustzcash crate.

The simple way would be to duplicate tests from the pure-Rust crates, and modify them to use the FFI methods. This would probably be rather hard to maintain. It would be great to figure out a strategy to reduce test duplication, while keeping the individual tests readable. Or we might decide that doing so isn't feasible, and just decide to duplicate test logic, in which case this is an easy issue to close 😄

@str4d str4d added the testing label Jan 15, 2019
@str4d str4d mentioned this issue Jan 15, 2019
CryptoForge pushed a commit to CryptoForge/librustzcash that referenced this issue Mar 3, 2019
@str4d
Copy link
Contributor Author

str4d commented Sep 10, 2020

We moved the FFI into https://github.com/zcash/zcash, so this issue is now obsolete. If we ever implement a general-purpose FFI, we can figure out testing of it then.

@str4d str4d closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant