Improvements to the strategy implemented by {fixed,standard,zip317}::SingleOutputChangeStrategy
#1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
fee-semantic-change
branch
from
71e9df8
to
977e6c8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
+ Coverage 63.08% 63.16% +0.08%
==========================================
Files 127 127
Lines 14821 14868 +47
==========================================
+ Hits 9350 9392 +42
- Misses 5471 5476 +5 ☔ View full report in Codecov by Sentry. |
str4d
reviewed
Jun 18, 2024
str4d
requested changes
Jun 18, 2024
daira
force-pushed
the
fee-semantic-change
branch
from
977e6c8
to
06bf360
Compare
daira
commented
Jun 19, 2024
daira
force-pushed
the
fee-semantic-change
branch
from
06bf360
to
7710919
Compare
…ategy` now implement a different strategy for choosing whether there will be any change, and its value. The aims are: * Ensure that it is possible to create fully transparent transactions with no change (this will be needed for ZIP 320). The `InsufficientFunds` error in this case should have a `required` field that reflects the additional amount needed, according to the fee calculated without an extra change output. * Avoid leaking information about note amounts in some cases: an adversary that knew the number of external recipients and the sum of their outputs was able to learn the sum of the inputs if no change output was present. * Defend against losing money by using `DustAction::AddDustToFee` with a too-high dust threshold. * Ensure that if a "change memo" is requested, there will always be a shielded change output in which to put it. Previously, this would not be the case when using `DustAction::AddDustToFee`. Co-authored-by: Jack Grigg <jack@electriccoin.co> Co-authored-by: Kris Nuttycombe <kris@nutty.land> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
fee-semantic-change
branch
from
7710919
to
21d5731
Compare
str4d
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zcash_client_backend::{fixed,standard,zip317}::SingleOutputChangeStrategynow implement a different strategy for choosing whether there will be any change, and its value. The aims are:ChangeError::InsufficientFundserror in this case should have arequiredfield that reflects the additional amount needed, according to the fee calculated without an extra change output.DustAction::AddDustToFeewith a too-high dust threshold.DustAction::AddDustToFee.