Update tests in testing/pool.rs to use ZIP 317 fees #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
- Coverage 63.16% 63.15% -0.01%
==========================================
Files 127 127
Lines 14868 14868
==========================================
- Hits 9391 9390 -1
- Misses 5477 5478 +1 ☔ View full report in Codecov by Sentry. |
str4d
reviewed
Jun 19, 2024
| @@ -921,18 +912,15 @@ pub(crate) fn spend_succeeds_to_t_addr_zero_change<T: ShieldedPoolTester>() { | |||
| let dfvk = T::test_account_fvk(&st); | |||
|
|
|||
| // Add funds to the wallet in a single note | |||
| let value = NonNegativeAmount::const_from_u64(60000); | |||
| let value = NonNegativeAmount::const_from_u64(70000); | |||
There was a problem hiding this comment.
Is this bump necessary for the test to work under ZIP 317, or is it left over from your other PR (that you subsequently undid)?
There was a problem hiding this comment.
No, this is necessary because the ZIP 317 fee is higher than 10000 zats. (Actually a value of 65000 zats would be sufficient, but this is not intended to be testing the zero-change corner case.)
| @@ -968,7 +956,7 @@ pub(crate) fn change_note_spends_succeed<T: ShieldedPoolTester>() { | |||
| let dfvk = T::test_account_fvk(&st); | |||
|
|
|||
| // Add funds to the wallet in a single note owned by the internal spending key | |||
| let value = NonNegativeAmount::const_from_u64(60000); | |||
| let value = NonNegativeAmount::const_from_u64(70000); | |||
str4d
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.