zcash_client_sqlite: Fix handling of PRAGMA directives. #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `foreign_keys` pragma has no effect when used within a transaction, so it should only be set at the top level. The `legacy_alter_table` pragma should only be used in cases where its effect is explicitly intended.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 63.16% 63.13% -0.03%
==========================================
Files 127 127
Lines 14868 14864 -4
==========================================
- Hits 9391 9385 -6
- Misses 5477 5479 +2 ☔ View full report in Codecov by Sentry. |
str4d
requested changes
Jun 19, 2024
Co-authored-by: str4d <thestr4d@gmail.com>
str4d
approved these changes
Jun 19, 2024
daira
reviewed
Jun 20, 2024
| "PRAGMA foreign_keys = OFF; | ||
| PRAGMA legacy_alter_table = TRUE;", | ||
| ) | ||
| .execute_batch("PRAGMA foreign_keys = OFF;") | ||
| .map_err(|e| MigratorError::Adapter(WalletMigrationError::from(e)))?; | ||
| let adapter = RusqliteAdapter::new(&mut wdb.conn, Some("schemer_migrations".to_string())); | ||
| adapter.init().expect("Migrations table setup succeeds."); |
There was a problem hiding this comment.
Pre-existing issue, but the ? early returns on lines 289 and 292 can bypass resetting PRAGMA foreign_keys = ON, leaving the database in a less-safe state.
daira
reviewed
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
foreign_keyspragma has no effect when used within a transaction, so it should only be set at the top level. Thelegacy_alter_tablepragma should only be used in cases where its effect is explicitly intended.Best reviewed hiding whitespace changes.