Initial primitives refactor #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebfull
approved these changes
Mar 7, 2019
| extern crate zcash_proofs; | ||
| extern crate zip32; | ||
|
|
||
| mod hashreader; | ||
|
|
||
| #[macro_use] | ||
| extern crate lazy_static; |
There was a problem hiding this comment.
Are we using anything from lazy_static now in the librustzcash crate?
There was a problem hiding this comment.
We call lazy_static::initialize(&JUBJUB) in librustzcash_init_zksnark_params(). If there's a better place to do this, e.g. as an explicit initialization function in zcash_primitives, then we could remove this dependency.
| @@ -48,6 +49,41 @@ pub struct TransactionData { | |||
| pub binding_sig: Option<Signature>, | |||
| } | |||
|
|
|||
| impl std::fmt::Debug for TransactionData { | |||
| fn fmt(&self, f: &mut std::fmt::Formatter) -> Result<(), std::fmt::Error> { | |||
| write!( | |||
There was a problem hiding this comment.
Alternatively could be written in the form:
write!(
f,
"TransactionData(
overwintered: {overwintered:?},
version: {version:?})",
overwintered=self.overwintered,
version=self.version,
)but because each field is used only once in the format, I don't think this needs to be changed from how it currently is.
There was a problem hiding this comment.
Ah, I hadn't stumbled on this form yet. I'll keep it in mind for future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for the individual changes.