Upgrade dependencies #94
Conversation
| .ok()?, | ||
| CHACHA20_BLOCK_SIZE + COMPACT_NOTE_SIZE | ||
| ); | ||
| // Start from block 1 to skip over Poly1305 keying output |
There was a problem hiding this comment.
Everything else LGTM but I'm curious what prompted this change?
There was a problem hiding this comment.
Also there is no longer an assert, that's fine yes?
There was a problem hiding this comment.
See #69 (comment) for the context.
There was a problem hiding this comment.
And yes, there's no longer an assert because ChaCha20Ietf::xor mutates in-place and doesn't return anything.
| // Start from block 1 to skip over Poly1305 keying output | ||
| let mut plaintext = [0; COMPACT_NOTE_SIZE]; | ||
| plaintext.copy_from_slice(&enc_ciphertext); | ||
| ChaCha20Ietf::xor(key.as_bytes(), &[0u8; 12], 1, &mut plaintext); |
There was a problem hiding this comment.
I'm assuming the 3rd argument is the signifier of which block to start from instead of prefixing with a 'block' of zero bytes?
There was a problem hiding this comment.
Correct. See RFC 7539 section 2.8 for details.
|
LGTM, will re-review once #92 is merged. |
|
Rebased on master to fix merge conflicts after #92 was merged. |
No description provided.