Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol Spec: Fix version constraint for valueBalanceSapling == 0 check #610

Closed
nuttycom opened this issue May 5, 2022 · 1 comment
Closed

Protocol Spec: Fix version constraint for valueBalanceSapling == 0 check #610

nuttycom opened this issue May 5, 2022 · 1 comment
Labels
protocol spec

Comments

@nuttycom
Copy link
Contributor

nuttycom commented May 5, 2022

image

The version check should be >= 4
@daira
Copy link
Collaborator

daira commented Aug 31, 2022

This is a [Sapling onward] rule, which means that effectiveVersion is necessarily 4 or 5. Before Sapling, the Spend description and Output description vectors were not present. So this is correct as-is.

image

@daira daira closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuttycom @daira