function/stdlib: ChunklistFunc precise mark handling #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will now preserve markings on individual input elements, without aggregating them on the returned top-level list. Marks on the list or on the chunk size will still propagate to the top-level return value. Chunklist previously didn't have any tests, so I've added some here in addition to the coverage for the mark handling. I also did some light reorganization so that the argument error handling happens before any of the short-circuit return paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will now preserve markings on individual input elements, without aggregating them on the returned top-level list.
Marks on the list or on the chunk size will still propagate to the top-level return value.
Chunklistpreviously didn't have any tests, so I've added some here in addition to the coverage for the mark handling. I also did some light reorganization so that the argument error handling happens before any of the short-circuit return paths.