force model fits to annotate against grand means #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I'll have a closer look later this week and may take the liberty to put some of these hyperparameters as arguments to the function. If nothing else it will at least help us clean up plots on a case-by-case basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out all that needed to be done for this is to subtract off the mean value of each factor and fit accordingly. This forces groups with less-than-average enrichment for a factor to drop out. To clean up further, a weight is derived from -log10(fdr) such that associations with an FDR > about 0.316 are dropped from the plot. If the user sets dropEmpty=TRUE, factors with no association at all will not be plotted (this is not the default... yet).