Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 atclone's exit code shoud be propagated to the parent zinit call #111

Closed
pschmitt opened this issue Nov 26, 2021 · 2 comments · Fixed by #112
Closed

💥 atclone's exit code shoud be propagated to the parent zinit call #111

pschmitt opened this issue Nov 26, 2021 · 2 comments · Fixed by #112
Labels
bug Something isn't working released
Milestone
v4.0.0

Comments

@pschmitt
Copy link
Member

zinit currently "silently" fails when the atclone script fails:

zinit id-as"atclone-fails" atclone'echo atclone; false' for zdharma-continuum/null && echo okay || echo failed

Downloading zdharma-continuum/null... (at label: atclone-fails...)

Cloning into '/data/plugins/atclone-fails'...
▸▹▹▹▹ ███████████ OBJ: 100, , REC: 100%
No files for compilation found.
atclone
okay

The snippet above should echo failed.
@pschmitt pschmitt added the bug Something isn't working label Nov 26, 2021
@pschmitt pschmitt added this to the zinit 4.0 milestone Nov 26, 2021
@pschmitt pschmitt changed the title 💥 atclone's exit code shoud be propagated the the parent zinit call 💥 atclone's exit code shoud be propagated to the parent zinit call Nov 26, 2021
@pschmitt pschmitt mentioned this issue Nov 26, 2021
Merged
@alichtman
Copy link
Member

Thanks for finding and fixing :)

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This issue has been resolved in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Pedantic warning: Return != 0 when a hook fails zdharma-continuum/zinit
2 participants
@pschmitt @alichtman