[gb57e13ff6] [Exhumed] Some menu sounds have gone quiet

[sinisterseed]

Namely, navigating the menus is silent now, all these sounds are gone, just the open menu sound still works.

[coelckers]

No problems here. All these sounds play as expected.

[sinisterseed]

Not for me, not anymore, in both self-compiled builds with 0.7.1's binaries and in DRD Team autobuilds.

Most curious. It actually got worse, going through the options is now quiet too.

[coelckers]

Please check the "Sound in menus" option,. I can confirm that I hear all the sounds you list as missing.

[sinisterseed]

Nope, nothing, and it's ON.

I only hear the mummy laughing and the open sound when opening the menu, after that, navigating the menus is silent.

[mjr4077au]

I can't validate this one myself, I hear all sounds like Graf can. Tested on multiple platforms as well.

Maybe blow your conf away and try fresh?

[mjr4077au]

Edited my comment above, been able to replicate this on a fresh config, but an older one is carrying over some setting perhaps. Investigating.

[mjr4077au]

Broken from a9ca6c8 onwards.

[coelckers]

Oh shit, I think this might the cause of most of those weird Exhumed sound issues. It allocated a sound info struct without fully initializing it. And here it just so happened that the change in size caused undefined behavior in a field that really could silence the sound. That commit was fine, it just changed the memory layout to change how the bug manifested itself.

@sinisterseed Can you check this out if you find some time and also cross check the other sound bugs? A potential fix has been committed

[mjr4077au]

This is dramatically better across the board and I'm hearing more sounds than I've heard thus far, but it's exacerbating some of those >>>>>>>>>>>> Received AL error Invalid Value (0xa003), oalsound.cpp:955 issues.

[coelckers]

I hope I can get them, too, so that I can investigate the reason. Good to hear that this seems to solve the problems. In hindsight it probably wasn't that bad that yesterday I did not manage to release 0.7.2. This sound fix is definitely worth a small delay. 😄

[mjr4077au]

Yeah, definitely is. I've seen comments about them persisting so finally getting them close to extinction is a great thing 😁.

[sinisterseed]

I go missing for a day and I see this now eh?

Damn awesome if this has revealed a deeper issue and now more sounds have been fixed :) . Time to kick ass.

Edited my comment above, been able to replicate this on a fresh config, but an older one is carrying over some setting perhaps. Investigating.

As I said, it was in both self-compiled builds and DRD Team ones, so it had to exist for real 😉 .

[coelckers]

It was actually quite obvious that some uninitialized data was at fault here. That linked commit just gave me an opportunity to look for when these newly added variables get set and suddenly I had found the place where something was not right.