Fixed drag & drop bug in IE 11 #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On drag start's dataTransfer store, the setData() function only accepts a string as second arguments, according to https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/setData While modern browsers stringify the null data type to "null" string value, drag & drop breaks in IE 11 when passing null to e.dataTranser.setData('text', null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On drag start's dataTransfer store, the setData() function only accepts a DOMString as second arguments, according to https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/setData
While modern browsers stringify the null data type to "null" string value, drag & drop functionality breaks in IE 11 when passing null to e.dataTranser.setData('text', null)
I simply fixed this by passing an empty string to the setData() function.