feat(plan/nodejs): add Docusaurus️ framework support #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan93412
requested changes
May 29, 2023
| @@ -411,6 +416,7 @@ func GetStaticOutputDir(ctx *nodePlanContext) string { | |||
| types.NodeProjectFrameworkVitepress: "docs/.vitepress/dist", | |||
| types.NodeProjectFrameworkAstroStatic: "dist", | |||
| types.NodeProjectFrameworkSliDev: "dist", | |||
| types.NodeProjectFrameworkDocusaurus: "build", | |||
There was a problem hiding this comment.
Is this output directory fixed? (users can't change it in an easy way)
There was a problem hiding this comment.
@pan93412 This should be the default output directory of the framework. If user change the config, they can pass the custom output path from buildOptions.
pan93412
reviewed
May 29, 2023
yuaanlin
approved these changes
May 29, 2023
|
Thanks for your contributions! ❤️ |
Closed
hackerchai
pushed a commit
to hackerchai/zbpack
that referenced
this pull request
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Docusaurus️ framework support