Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error doesn't display when loading custom certs for registry token #11

Closed
zebox opened this issue Feb 1, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@zebox
Copy link
Owner

zebox commented Feb 1, 2023

When user try use own certificates and try loading they for registry token, loadCerts can throw an error, but it doesn't shows. If error exist registry-admin try creates new certs. The createCerts throw an error to because user certs already exist in destination folder.

// in registry/token.go package

if err = rt.loadCerts(); err != nil {
		err = rt.createCerts()
		if err != nil {
			return nil, err
		}
	}

Need handle loadCerts errors before call createCerts.

@zebox zebox added bug Something isn't working invalid This doesn't seem right labels Feb 1, 2023
@zebox zebox self-assigned this Feb 1, 2023
@zebox zebox changed the title Errors not show when loading custom certs for registry token Error doesn't displays when loading custom certs for registry token Feb 2, 2023
@zebox zebox changed the title Error doesn't displays when loading custom certs for registry token Error doesn't display when loading custom certs for registry token Feb 2, 2023
zebox added a commit that referenced this issue Feb 3, 2023
When user try use own certificates and try loading them for registry token, loadCerts can get an error, but it doesn't display. If error exist registry-admin try creates new certs. The createCerts throw an error because user certs already exist in a destination folder.
zebox added a commit that referenced this issue Feb 4, 2023
zebox added a commit that referenced this issue Feb 4, 2023
When user try use own certificates and try loading them for registry token, loadCerts can get an error, but it doesn't display. If error exist registry-admin try creates new certs. The createCerts throw an error because user certs already exist in a destination folder.
@zebox
Copy link
Owner Author

zebox commented Feb 4, 2023

Fixed.

@zebox zebox closed this as completed Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant