Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix taproot crate #1

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Conversation

mimoo
Copy link

@mimoo mimoo commented Dec 13, 2023

not sure why it's so messy, I can try to create another clean PR if you want :)

the changes are here: https://github.com/mimoo/frost/commits/mimoo/fix5/ and are basically what I pointed out in the comments in ZcashFoundation#584

(if you rebase on top of the latest changes in frost, and run cargo fmt, then I can create a clean PR)

@zebra-lucky
Copy link
Owner

Thank your for your work!

I'll look more closely in few days.

Currently looking for DKG generating only even Y.

@zebra-lucky
Copy link
Owner

zebra-lucky commented Dec 24, 2023

I'll try to check out PR code locally to test

git fetch origin pull/1/head:PR1
git checkout PR1

@zebra-lucky
Copy link
Owner

I've seen proposed changes, and need reread BIP340/341
on oddness of Y related to tweaked public key.

@zebra-lucky
Copy link
Owner

Trying to reproduce a problem without proposed changes.

@zebra-lucky
Copy link
Owner

A problem with odd tweaked public key is reproduced.

Adding proposed changes and testing again.

@zebra-lucky
Copy link
Owner

@mimoo, thanks you again for your work!

I've tested your changes and it's work fine.

I've rebased base branch on 6d82adf, plus processed code
with cargo fmt, so you can rebase your PR branch to simplify merge.

@mimoo
Copy link
Author

mimoo commented Dec 27, 2023

awesome I'll clean this up then :)

@mimoo
Copy link
Author

mimoo commented Dec 27, 2023

here you go!

@zebra-lucky zebra-lucky merged commit 0e5e083 into zebra-lucky:add-secp256k1-tr Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants