-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix taproot crate #1
Conversation
Thank your for your work! I'll look more closely in few days. Currently looking for DKG generating only even |
I'll try to check out PR code locally to test
|
1f4b852
to
6fdd873
Compare
I've seen proposed changes, and need reread BIP340/341 |
Trying to reproduce a problem without proposed changes. |
A problem with odd tweaked public key is reproduced. Adding proposed changes and testing again. |
awesome I'll clean this up then :) |
here you go! |
not sure why it's so messy, I can try to create another clean PR if you want :)
the changes are here: https://github.com/mimoo/frost/commits/mimoo/fix5/ and are basically what I pointed out in the comments in ZcashFoundation#584
(if you rebase on top of the latest changes in frost, and run
cargo fmt
, then I can create a clean PR)