Dockerized #11
Closed
Dockerized #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM! Thank you - I really like the approach with dep. |
|
Haven`t forgotten this. Just zero time, sorry! |
|
I would strongly encourage using the alpine docker containers for testing. Not only would it make CI faster since it won't have to download a larger docker image...it would be faster for people to run the test suite locally. |
|
Agree. Sorry I won't submit another commit to this PR, the latest FROM alpine
ENV GOPATH /go
ENV PATH $PATH:$GOROOT/bin:$GOPATH/bin
ENV APP_DIR $GOPATH/src/mongodm
RUN apk add --no-cache --update go git libc-dev && \
mkdir -p $APP_DIR && \
go get -u github.com/golang/dep/cmd/dep && \
apk del git
ADD . $APP_DIR
WORKDIR $APP_DIR
|
moehlone
added a commit
that referenced
this pull request
Feb 7, 2018
…isCI (#14) * chore: dockerized and use dep to manage dependencies * fix: add 'Source' option to Config * rebase mixed code * chore: Use golang:alpine image to shrink final size * feat: Add travis.yml * chore: Use native go environment * fix: Add mongodb for travis * fix: switch back to docker-compose for travis * Update readme for #11 * chore: Add TravisCI badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include two commits, one for dockerized, and the other one fix the
authenticationDatabaseproblem.Dockerized
With docker, you do not need to install
goandmongodbon your local machine, it's easy to setup development environment for this repository.Prerequisites
Make sure you already installed below programs on your local machine:
gitdockerdocker-composeUsage
Just run
make test, it will build the docker container and rungo test.dep
dep is a prototype dependency management tool for Go.
To use
depin the container, prefixmakefor alldepcommands, for example:$ make dep "ensure -add github.com/some/repos"Beware that the double quotes are required after
make depcommand.Authentication problem (Optional)
According to mgo DialInfo documents, the option
Sourceis the database used to establish credentials and privileges with a MongoDB server. Defaults to the value ofDatabase, if that is set, or "admin" otherwise.Because we set the
Databaseoption inConfigObject, so theauthenticationDatabaseargument was set tomongodm_testthat could not connect to mongodb server correctly.The second commit solved this problem, it's optional to merge, but I think it's better to fully support options of
DialInfo.