retain_task shouldn't kill appium in between session

[vdelendik]

As of now we still need selenium grid with all devices connected which is pretty old school.
When we do hard appium restart in between sessions it kill selenium node and reconnect asap but grid itself still continue to use old connection.
As result 2nd test crash with below exception.

let's investigate the approach when we cleanup appium log file instead of hard kill and start to keep appium and selenium grid connection.

org.openqa.selenium.WebDriverException: Session [2bb6140d-2f55-4bfd-b86b-7655c570972b] not available and is not among the last 1000 terminated sessions.
Active sessions are[]
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
System info: host: '...', ip: '192.168.2.99', os.name: 'Windows 10', os.arch: 'amd64', os.version: '10.0', java.version: '11.0.11'
Driver info: io.appium.java_client.android.AndroidDriver
Capabilities {app: https://qaprosoft.s3-us-wes..., appPackage: com.solvd.carinademoapplica..., carinaTestRunId: 02c04faa-a508-412e-beca-27f..., databaseEnabled: false, desired: {app: https://qaprosoft.s3-us-wes..., carinaTestRunId: 02c04faa-a508-412e-beca-27f..., deviceName: Samsung_S5, enableVideo: true, enableVnc: true, language: en, locale: US, platformName: android, provider: zebrunner, server:CONFIG_UUID: 841d86f8-1a4f-4748-afd6-180..., slotCapabilities: {adb_port: 7500, automationName: Appium, deviceName: Samsung_S5, deviceType: Phone, maxInstances: 1, platform: ANDROID, platformName: ANDROID, platformVersion: 6.0.1, proxy_port: 7550, remoteURL: demo.zebrunner.farm:7412, seleniumProtocol: WebDriver, server:CONFIG_UUID: 841d86f8-1a4f-4748-afd6-180..., udid: 4d003e5f4aad21e7, version: 6.0.1, vncLink: ws://demo.zebrunner.farm:7420}}, deviceApiLevel: 23, deviceManufacturer: samsung, deviceModel: SM-G900H, deviceName: 4d003e5f4aad21e7, deviceScreenDensity: 480, deviceScreenSize: 1080x1920, deviceUDID: 4d003e5f4aad21e7, enableVideo: true, enableVnc: true, javascriptEnabled: true, language: en, locale: US, locationContextEnabled: false, networkConnectionEnabled: true, pixelRatio: 3, platform: LINUX, platformName: ANDROID, platformVersion: 6.0.1, provider: zebrunner, server:CONFIG_UUID: 841d86f8-1a4f-4748-afd6-180..., slotCapabilities: {adb_port: 7500, automationName: Appium, deviceName: Samsung_S5, deviceType: Phone, maxInstances: 1, platform: ANDROID, platformName: ANDROID, platformVersion: 6.0.1, proxy_port: 7550, remoteURL: demo.zebrunner.farm:7412, seleniumProtocol: WebDriver, server:CONFIG_UUID: 841d86f8-1a4f-4748-afd6-180..., udid: 4d003e5f4aad21e7, version: 6.0.1, vncLink: ws://demo.zebrunner.farm:7420}, statBarHeight: 72, takesScreenshot: true, viewportRect: {height: 1848, left: 0, top: 72, width: 1080}, warnings: {}, webStorageEnabled: false}
Session ID: 2bb6140d-2f55-4bfd-b86b-7655c570972b
*** Element info: {Using=id, value=next_button}

[vdelendik]

fixed. during the testing

1. run regular mobile sample test
   -> all 3 should executed, for each session video and session.log registered in the reporting
2. override capabilities.app to use invalid non existing path and execute test
   -> all 3 tests should fail but we should see for each of them session.log attached obligatory. for some of them even video might be generated
3. run with invalid path and device with pin
   -> all 3 tests should have session.log obligatory and 90% that video as well how device is unpined

Note: step 2 and 3 should be done only with 7.3.15+ or 7.3.15-SNAPSHOT as only in this version we deliver fallbackSessionId for reference. Exact reporting build and env - still TBD

[dhreben]

Verified.