Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tokyo Night Storm extensions #881

Closed
wants to merge 1 commit into from

Conversation

ZeroHawkeye
Copy link

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 7, 2024
@maxdeviant
Copy link
Member

How does this differ from the Tokyo Night Storm theme in the tokyo-night extension?

https://github.com/ssaunderss/zed-tokyo-night/blob/fb2c765772a1096c52d44ece746f661460bed9e8/themes/tokyo-night.json#L615-L616

@ZeroHawkeye
Copy link
Author

In my golang language, such as the routing file of the gin framework, the individual func handler will not be highlighted, but this theme will be highlighted

@ZeroHawkeye
Copy link
Author

And the overall color scheme of the theme is different. I think this theme is more comfortable.

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-is, I think having both "Tokyo Night" and a separate "Tokyo Night Storm" extension is going to be confusing for users.

If you give your extension a different name then I think we can move forward with it.

@maxdeviant maxdeviant closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants