Skip to content

Commit

Permalink
Add yss operation support for vim surrounds: (#11084)
Browse files Browse the repository at this point in the history
The Motion::CurrentLine operation will contain the newline of the
current line, so we need to deal with this edge case



Release Notes:

- N/A
  • Loading branch information
weartist authored Apr 30, 2024
1 parent ad44237 commit 4fad96b
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 8 deletions.
6 changes: 6 additions & 0 deletions assets/keymaps/vim.json
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,12 @@
]
}
},
{
"context": "Editor && vim_operator == ys",
"bindings": {
"s": "vim::CurrentLine"
}
},
{
"context": "Editor && VimObject",
"bindings": {
Expand Down
52 changes: 44 additions & 8 deletions crates/vim/src/surrounds.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::{motion::Motion, object::Object, state::Mode, Vim};
use editor::{scroll::Autoscroll, Bias};
use editor::{movement, scroll::Autoscroll, Bias};
use gpui::WindowContext;
use language::BracketPair;
use serde::Deserialize;
Expand Down Expand Up @@ -47,13 +47,32 @@ pub fn add_surrounds(text: Arc<str>, target: SurroundsType, cx: &mut WindowConte
SurroundsType::Object(object) => {
object.range(&display_map, selection.clone(), false)
}
SurroundsType::Motion(motion) => motion.range(
&display_map,
selection.clone(),
Some(1),
true,
&text_layout_details,
),
SurroundsType::Motion(motion) => {
let range = motion
.range(
&display_map,
selection.clone(),
Some(1),
true,
&text_layout_details,
)
.map(|mut range| {
// The Motion::CurrentLine operation will contain the newline of the current line,
// so we need to deal with this edge case
if let Motion::CurrentLine = motion {
let offset = range.end.to_offset(&display_map, Bias::Left);
if let Some((last_ch, _)) =
display_map.reverse_buffer_chars_at(offset).next()
{
if last_ch == '\n' {
range.end = movement::left(&display_map, range.end);
}
}
}
range
});
range
}
};

if let Some(range) = range {
Expand Down Expand Up @@ -591,6 +610,23 @@ mod test {
the laˇ1zy dog.1"},
Mode::Normal,
);

// test add surrounds with motion current line
cx.set_state(
indoc! {"
The quˇick brown
fox jumps over
the lazy dog."},
Mode::Normal,
);
cx.simulate_keystrokes(["y", "s", "s", "{"]);
cx.assert_state(
indoc! {"
ˇ{ The quick brown }
fox jumps over
the lazy dog."},
Mode::Normal,
);
}

#[gpui::test]
Expand Down

0 comments on commit 4fad96b

Please sign in to comment.