Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust test current function not working #10925

Closed
1 task done
kzhui125 opened this issue Apr 24, 2024 · 2 comments · Fixed by #10929
Closed
1 task done

rust test current function not working #10925

kzhui125 opened this issue Apr 24, 2024 · 2 comments · Fixed by #10929
Labels
bug [core label] tasks

Comments

@kzhui125
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

image

rust test current function not working when the package name different from folder name.

[package]
name = "abc-folder"

Environment

Zed: v0.131.7 (Zed)
OS: macOS 14.4.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@kzhui125 kzhui125 added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Apr 24, 2024
@SomeoneToIgnore
Copy link
Contributor

Looks like a duplicate of #10915 so will close it.

@SomeoneToIgnore SomeoneToIgnore closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Apr 24, 2024
Merged
@SomeoneToIgnore
Copy link
Contributor

Fixed in #10929 and should appear in the next Zed update later today.

@SomeoneToIgnore SomeoneToIgnore mentioned this issue Apr 24, 2024
Closed
1 task
SomeoneToIgnore added a commit that referenced this issue Apr 24, 2024
@SomeoneToIgnore
Properly extract package name out of cargo pkgid (#10929)
6108140 
Fixes #10925

Uses correct package name to generate Rust `cargo` tasks.
Also deduplicates lines in task modal item tooltips.

Release Notes:

- Fixed Rust tasks using incorrect package name
([10925](#10925))
SomeoneToIgnore added a commit that referenced this issue Apr 24, 2024
@SomeoneToIgnore
Properly extract package name out of cargo pkgid (#10929)
81cb4ee 
Fixes #10925

Uses correct package name to generate Rust `cargo` tasks.
Also deduplicates lines in task modal item tooltips.

Release Notes:

- Fixed Rust tasks using incorrect package name
([10925](#10925))
@Moshyfawn Moshyfawn added tasks and removed triage Maintainer needs to classify the issue labels Apr 24, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly extract package name out of cargo pkgid zed-industries/zed
4 participants
@SomeoneToIgnore @kzhui125 @Moshyfawn @JosephTLyons