Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect lines indentation when interacting with git diff and git blame #11941

Closed
1 task done
unemil opened this issue May 16, 2024 · 2 comments
Closed
1 task done

Incorrect lines indentation when interacting with git diff and git blame #11941

unemil opened this issue May 16, 2024 · 2 comments
Labels
bug [core label] git blame git Git integration feedback

Comments

@unemil
Copy link

unemil commented May 16, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

It's my first issue report, don't judge me too harshly :)

When using git diff with git blame, indentation for deleted lines is triggered incorrectly.

Environment

Zed: v0.135.2 (Zed)
OS: macOS 14.5.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screen.Recording.2024-05-17.at.01.17.44.mov

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@unemil unemil added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels May 16, 2024
@unemil unemil changed the title Incorrect indentation at actions git diff and git blame Incorrect indentation when interacting with git diff and git blame May 16, 2024
@unemil unemil changed the title Incorrect indentation when interacting with git diff and git blame Incorrect lines indentation when interacting with git diff and git blame May 16, 2024
@github-actions github-actions bot mentioned this issue May 17, 2024
Open
@JosephTLyons JosephTLyons added git Git integration feedback git blame and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 17, 2024
@JosephTLyons
Copy link
Collaborator

Thanks for the report, @unemil!

@bennetbo bennetbo mentioned this issue May 29, 2024
Merged
bennetbo added a commit that referenced this issue May 29, 2024
@bennetbo
Fix deleted hunk offset when zooming (#12442)
a22cd95 
Release Notes:

- Fixed an issue where expanded hunks could be rendered at the wrong
position when zooming
- Fixed an issue where expanded hunks could be rendered at the wrong
position when toggling git blame
([#11941](#11941))
@bennetbo
Copy link
Collaborator

Should be fixed by #12442

maxbrunsfeld pushed a commit that referenced this issue May 29, 2024
@bennetbo @maxbrunsfeld
Fix deleted hunk offset when zooming (#12442)
5a2297c 
Release Notes:

- Fixed an issue where expanded hunks could be rendered at the wrong
position when zooming
- Fixed an issue where expanded hunks could be rendered at the wrong
position when toggling git blame
([#11941](#11941))
maxbrunsfeld pushed a commit that referenced this issue May 29, 2024
@bennetbo @maxbrunsfeld
Fix deleted hunk offset when zooming (#12442)
360cc36 
Release Notes:

- Fixed an issue where expanded hunks could be rendered at the wrong
position when zooming
- Fixed an issue where expanded hunks could be rendered at the wrong
position when toggling git blame
([#11941](#11941))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] git blame git Git integration feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JosephTLyons @unemil @bennetbo