Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang: Backticks autoclosing does not work #12025

Closed
1 task done
ZeroHawkeye opened this issue May 19, 2024 · 2 comments · Fixed by #12050
Closed
1 task done

golang: Backticks autoclosing does not work #12025

ZeroHawkeye opened this issue May 19, 2024 · 2 comments · Fixed by #12050
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label] go Go programming language support language An umbrella label for all programming languages syntax behaviors

Comments

@ZeroHawkeye
Copy link

Check for existing issues

  • Completed

Describe the feature

image
As you can see above, the automatic closing of double quotes after typing the first backtick is also disabled.

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@ZeroHawkeye ZeroHawkeye added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels May 19, 2024
@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc language An umbrella label for all programming languages syntax behaviors go Go programming language support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 19, 2024
@osiewicz osiewicz changed the title The automatic closing of single quotes of tag tags in golang does not work golang: Backticks autoclosing does not work May 20, 2024
osiewicz added a commit that referenced this issue May 20, 2024
@osiewicz
golang: autoclose backticks
b7f9695 
Fixes #12025
@osiewicz osiewicz mentioned this issue May 20, 2024
Merged
@osiewicz
Copy link
Contributor

the automatic closing of double quotes after typing the first backtick is also disabled.
That's kind of expected, as we disable it while in another string or comment.

I've already got a PR up for backticks autoclosing though, thanks for spotting that.

osiewicz added a commit that referenced this issue May 20, 2024
@osiewicz
golang: autoclose backticks (#12050)
7db85b0 
Fixes #12025



Release Notes:
- Fixed backtick characters not getting autoclosed in Golang files
(#12025).
@ZeroHawkeye
Copy link
Author

image
This problem does not seem to be completely solved. For example, when ``internal input", double quotes cannot be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label] go Go programming language support language An umbrella label for all programming languages syntax behaviors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

golang: autoclose backticks zed-industries/zed
3 participants
@JosephTLyons @osiewicz @ZeroHawkeye