Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build Zed without auto_update feature #12588

Closed
1 task done
jirutka opened this issue Jun 2, 2024 · 2 comments · Fixed by #12660
Closed
1 task done

Allow to build Zed without auto_update feature #12588

jirutka opened this issue Jun 2, 2024 · 2 comments · Fixed by #12660
Labels
enhancement [core label] installer / updater Feedback for installation and update process setting Feedback for preferences, configuration, etc

Comments

@jirutka
Copy link

jirutka commented Jun 2, 2024

Check for existing issues

  • Completed

Describe the feature

If Zed is installed using a package manager, the auto_update feature is undesirable – the updates are handled by the package manager. Can you please put it behind feature gate so that distros can build Zed without the auto_update feature and its dependencies?

Related issues: #11114

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@jirutka jirutka added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jun 2, 2024
@Moshyfawn Moshyfawn added needs info / awaiting response Issue that needs more information from the user installer / updater Feedback for installation and update process setting Feedback for preferences, configuration, etc and removed triage Maintainer needs to classify the issue needs info / awaiting response Issue that needs more information from the user labels Jun 2, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Jun 4, 2024
@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Jun 4, 2024

I see that a PR has been opened for this already, but just wanted to mention that you can disable this locally via your settings.json file with:

"auto_update": true

I realize that isn't as desirable, but it is a workaround in the meanwhile.

@someone13574
Copy link
Contributor

I see that a PR has been opened for this already, but just wanted to mention that you can disable this locally via your settings.json file with:

"auto_update": true

I realize that isn't as desirable, but it is a workaround in the meanwhile.

The idea is that there should be an option to override this setting for installations done through package managers so that there aren't cases where a user enables it and then the package gets broken in one of the numerous ways it could be (eg. non-glibc systems, shared dep mismatches, etc.).

mikayla-maki added a commit that referenced this issue Jun 4, 2024
Supersedes #12659
Fixes #12588

One of Zed's core features is our collaboration software. As such, it is
important that we notify the user when their RPC protocol is out of
date, and how to update it. This PR adds a mechanism to replace the
existing auto updater with a message explaining how to update Zed for
this environment.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] installer / updater Feedback for installation and update process setting Feedback for preferences, configuration, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants