-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support client/registerCapability
LSP requests for formatting methods
#12661
Comments
@luckydye , I have drafted a branch with the change: https://github.com/zed-industries/zed/compare/kb/format-capabilities?expand=1 but failed to format via biome. Can you help me with testing it? |
@SomeoneToIgnore Awesome! I tried it myself once too, but im too much of a Rust noob still 🥲 So it actually works for me. Try this config: "language_servers": [ "biome" ], The only problem now is, that we can't choose the "primary" language server used for the formatting. (#11288) |
Hmm, that almost works for me now, thank you.
I fear, we also would need to add more logic for plugin retrieval in this case, but one step at a time I guess. I am able to format standalone (no package.json and node_modules around) json files like All happens with the same
config. I do not have much bandwidth to explore all those things, but seems that a bit more work is needed on that front. I'll merge the PR and close this issue as it seems fixed. |
Check for existing issues
Describe the feature
Currently
client/registerCapability
Language Server requests for formatting methods are ignored, which causes certain language-servers to not format files even though they could.Specifically
textDocument/rangeFormatting
,textDocument/onTypeFormatting
andtextDocument/formatting
.Related to biomejs/biome-zed#5.
If applicable, add mockups / screenshots to help present your vision of the feature
No response
The text was updated successfully, but these errors were encountered: