Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file icon is always displayed when renaming a file #12905

Closed
1 task done
arnimattr opened this issue Jun 11, 2024 · 0 comments · Fixed by #12910
Closed
1 task done

file icon is always displayed when renaming a file #12905

arnimattr opened this issue Jun 11, 2024 · 0 comments · Fixed by #12910
Labels
bug [core label] file icons Feedback for file icons visualisation, file type recognition, etc project panel Feedback for files tree view

Comments

@arnimattr
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When renaming a file, its icon is always shown even if project_panel.file_icons is set to false in Zed's config – I'm not sure whether this is intentional or not!

Environment

Zed: v0.137.6 (Zed)
OS: macOS 14.3.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@arnimattr arnimattr added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jun 11, 2024
maxdeviant added a commit that referenced this issue Jun 11, 2024
… otherwise hidden (#12910)

This PR fixes an instance where the file icon for a project panel entry
would be shown during a rename even when the `project_panel.file_icons`
setting was set to `false`.

Resolves #12905.

Release Notes:

- Fixed an issue where file icons were displayed in the project panel
during a rename even when `project_panel.file_icons` was set to `false`
([#12905](#12905)).
@JosephTLyons JosephTLyons added project panel Feedback for files tree view file icons Feedback for file icons visualisation, file type recognition, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 12, 2024
ming900518 pushed a commit to ming900518/zed that referenced this issue Jun 14, 2024
… otherwise hidden (zed-industries#12910)

This PR fixes an instance where the file icon for a project panel entry
would be shown during a rename even when the `project_panel.file_icons`
setting was set to `false`.

Resolves zed-industries#12905.

Release Notes:

- Fixed an issue where file icons were displayed in the project panel
during a rename even when `project_panel.file_icons` was set to `false`
([zed-industries#12905](zed-industries#12905)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] file icons Feedback for file icons visualisation, file type recognition, etc project panel Feedback for files tree view
Projects
None yet
2 participants