Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vim: ctrl-d and ctrl-u bugs when used with scroll_beyond_last_line off #15356

Closed
1 task done
ksweetie opened this issue Jul 27, 2024 · 1 comment · Fixed by #15395
Closed
1 task done

Vim: ctrl-d and ctrl-u bugs when used with scroll_beyond_last_line off #15356

ksweetie opened this issue Jul 27, 2024 · 1 comment · Fixed by #15395
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc vim

Comments

@ksweetie
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

There are three related buggy behaviors. I'd be happy to split these into separate issues if you'd prefer that.

All of these are with the setting "scroll_beyond_last_line": "off", which matches the behavior of neovim.

  1. ctrl-d can't reach the bottom of the buffer.
  2. If the cursor is already further down than the point it could otherwise reach via ctrl-d, it will actually go up.
  3. When the cursor is on the last line, ctrl-u will scroll up, but the cursor won't move with it. It stays on the last line.

Environment

Zed: v0.145.1 (Zed)
OS: macOS 14.4.1
Memory: 16 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Video showing the first two bugs:

Screen.Recording.2024-07-27.at.1.47.48.PM.mov

Video showing the third bug:

Screen.Recording.2024-07-27.at.1.49.02.PM.mov

The same commands in neovim:

Screen.Recording.2024-07-27.at.1.57.24.PM.mov

If applicable, attach your Zed.log file to this issue.

No response
@ksweetie ksweetie added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jul 27, 2024
@notpeter notpeter added vim editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 28, 2024
@github-actions github-actions bot mentioned this issue Jul 28, 2024
Open
@ksweetie
Copy link
Contributor Author

I think I have fixes for these issues. I'll open a PR.

@ksweetie ksweetie mentioned this issue Jul 29, 2024
Merged
ConradIrwin pushed a commit that referenced this issue Aug 23, 2024
@ksweetie @maxdeviant
Fix ctrl-d/u issues with scroll_beyond_last_line off (#15395)
5e869da 
Closes #15356

Release Notes:

- vim: Fixed issues with `ctrl-d`/`ctrl-u` when
`scroll_beyond_last_line` is set to `off`
([#15356](#15356)).


https://github.com/user-attachments/assets/d3166393-4a4e-4195-9db6-3ff1d4aeec78

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
@baptisteArno baptisteArno mentioned this issue Aug 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ctrl-d/u issues with scroll_beyond_last_line off ksweetie/zed
2 participants
@notpeter @ksweetie