Search for symbols Cmd+T not finding function names

[insane-dreamer]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Pressing Cmd+T in a project .py file brings up Search Project Symbol box, but typing there yields no results (even though the left-side panel shows all the functions and I can filter there using the filter box at the bottom of that panel). As I type, box continues to show "no matches". No error messages in log when pressing Cmd+T.

I do not have Zig extension installed (as in the recent issue reporting a similar problem).

Environment

OSX, M3

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

No error messages being generated in logs at the time of issuing the command. The most recent log messages (likely unrelated), are below. 

2024-08-02T15:45:33.450287Z [ERROR] no worktree found for diagnostics path "/Users/---/.config/zed/settings.json"
2024-08-02T15:49:59.882951Z [INFO] starting language servers for Python: pyright, ruff
2024-08-02T15:49:59.883096Z [INFO] starting language server "ruff", path: "/Users/---/Library/Application Support/Zed/languages/pyright/node_modules/pyright/dist/typeshed-fallback/stdlib/builtins.pyi", id: 9
2024-08-02T15:50:00.632013Z [INFO] starting language server. binary path: "/Users/---/Library/Application Support/Zed/extensions/work/ruff/ruff-0.5.5/ruff-aarch64-apple-darwin/ruff", working directory: "/Users/---/Library/Application Support/Zed/languages/pyright/node_modules/pyright/dist/typeshed-fallback/stdlib", args: ["server"]
2024-08-02T15:50:02.530443Z [ERROR] no worktree found for diagnostics path "/Users/---/Library/Application Support/Zed/languages/pyright/node_modules/pyright/dist/typeshed-fallback/stdlib/builtins.pyi"
2024-08-02T15:50:02.530801Z [ERROR] no worktree found for diagnostics path "/Users/---/Library/Application Support/Zed/languages/pyright/node_modules/pyright/dist/typeshed-fallback/stdlib/builtins.pyi"

[maxdeviant]

Searching project symbols requires the language server to support it.

AFAIK our default Python language server, pyright, does not support this.

[JosephTLyons]

It think @maxdeviant is correct, this is a deficiency of the pyright language server. I would normally encourage users to go report missing features at the source, but I wouldn't count on the maintainers of pyright to add something like this, as they are mostly only concerned with type checking. Hopefully, we get an open source language server for Python that competes with Pylance in the near future.

I'm going to close this out, as it is currently out of our hands, unless we build our own language server.

[burlakov-nick]

I am pretty sure it worked for me before on Python project 🤔
I tried to reproduce with older versions of Zed, got no luck

[SirSilver]

Pyright actually has workspace symbols feature. But for some reason it's not working if I use pyright alongside with ruff.

For example:
I have a.py module

def a():
    return

And I'm trying to search a from __init__.py
When only pyright in language_servers

{
  "languages": {
    "Python": {
      "language_servers": ["pyright"]
    }
  }
}

Zed can successfully find a project symbol

But as soon as I add ruff in language_servers:

{
  "languages": {
    "Python": {
      "language_servers": ["pyright", "ruff"]
    }
  }
}

There are no matches