When shift is pressed, the string shift is printed

[jizhi0v0]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

when knock the shift key, the string shift is append in current line

CleanShot.2024-11-21.at.11.47.06.mp4

Environment

zed preview 0.162.3 version
Apple M3 Max
36 GB
15.1 (24B83)

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

[Zed.log](https://github.com/user-attachments/files/17839514/Zed.log)

[jizhi0v0]

This issue only in 0.163.0 preview and 0.162.3 stable

[jizhi0v0]

git bisect start
git bisect good v0.161.2
git bisect bad v0.162.3

Finally c4a382d is the first bad commit

[caturbgs]

This is very frustrating issue I got today after updating Zed, hope this will take up soon

[eatenpancreas]

Having the same issue here

[lebe-dev]

Approved, v0.161.2 is not affected

[piechologist]

Do you all have a key binding for "shift shift"?

For me, pressing shift twice runs the bound action as intended. Pressing shift just once inserts shift into the editor after a split second. Removing the key binding solves the issue.

The same issue occurs with the other modifiers e.g., binding "cmd cmd" inserts platform.

[BraisonCrece]

Do you all have a key binding for "shift shift"?

For me, pressing shift twice runs the bound action as intended. Pressing shift just once inserts shift into the editor after a split second. Removing the key binding solves the issue.

The same issue occurs with the other modifiers e.g., binding "cmd cmd" and inserts platform.

Yes, I have shift shift binding and disabling it fixes the problem 👍

[eatenpancreas]

@piechologist do you mean like this? I'm getting it but very inconsistently so

[eatenpancreas]

I figured out what's causing it on my end (sort of).

For me, it's only happening if i select something, while selected press shift (just once) and then leave the selection by clicking somewhere else. It'll then just get pasted wherever i clicked to next.

Screen.Recording.2024-11-21.at.12.25.12.mov

[piechologist]

For me, it's only happening if i select something

I can't replicate that. It doesn't matter if there's a selection or not. With the shift shift binding commented out, nothing gets inserted.

[xplodwild]

Same happens for me on Linux v0.162.3, with a "shift shift" keybinding enabled, pressing shift then an arrow key leads to "shift" being inserted in the current buffer.

Disabling/commenting my "shift shift" keybinding, the problem goes away immediately.

[blueambr]

I don't have any bindings and this happens. It's a ridiculously annoying bug. Wonder how it was introduced into the stable build.

[HarshNarayanJha]

Can confirm. It is happening on the latest stable. I do have a shift-shift key binding to open ctrl+p menu

System Info

Zed: v0.162.3 (Zed)
OS: Linux Wayland garuda unknown
Memory: 7.1 GiB
Architecture: x86_64
GPU: AMD Radeon Graphics (RADV RENOIR) || radv || Mesa 24.2.7-arch1.1

[VladimirTaytor]

Same here. I don't have "shift shift" custom bindings, but I do have "base_keymap": "JetBrains"
Please take a look asap, it's very annoying 🙏

[eatenpancreas]

Same here. I don't have "shift shift" custom bindings, but I do have "base_keymap": "JetBrains" Please take a look asap, it's very annoying 🙏

now that you say it, i also have JetBrains base keymap as well, so that could be a part of it

[modelga]

Hi!, It's bothering me too, additionally, when I add an extra keybinding "cmd cmd": "workspace::ToggleZoom" I've got another text inserted in editor -> platform while I pressed 'cmd' only once and then clicked somewhere else. I have base_keymap derived from VSCode.

Using MacOS 14.7.1 on M1 arm64 architecture

[piechologist]

Zed Preview 0.163.1 is out with a fix.

Thanks to the Zed team for the quick response! 🚀