Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treating Vue template prop binding and mustache text interpolation as JS/TS syntax (for highlighting) #8989

Closed
1 task done
rev4324 opened this issue Mar 7, 2024 · 1 comment · Fixed by #11482
Closed
1 task done
Labels
enhancement [core label] language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors vue Vue.js framework support

Comments

@rev4324
Copy link

rev4324 commented Mar 7, 2024

Check for existing issues

  • Completed

Describe the feature

It would be great if Zed would treat Vue prop bindings with :prop syntax and text interpolation mustache syntax {{ }} as JS/TS. Here's a little comparison of Zed and Neovim with tree-sitter in that regard to demonstrate what I mean:

neovim:
image

Zed:
image

As you can hopefully see, in neovim :prop props are using member_expression nodes, while in Zed all attributes are treated equally - with quoted_attribute_value nodes. There are also other instances where this JS syntax highlighting would be useful and is already there in nvim and vscode - like v-for, v-if and other v- directives or aformentioned mustache text interpolation {{ }} syntax.

If applicable, add mockups / screenshots to help present your vision of the feature

As in the description, Vue syntax highlighting working like in Neovim.
image

@rev4324 rev4324 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Mar 7, 2024
@Moshyfawn Moshyfawn added markdown Markdown markup support language An umbrella label for all programming languages syntax behaviors language server An umbrella label for all language servers vue Vue.js framework support and removed markdown Markdown markup support triage Maintainer needs to classify the issue labels Mar 7, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 7, 2024
@Amstrong

This comment has been minimized.

maxbrunsfeld pushed a commit that referenced this issue Jun 4, 2024
maxdeviant pushed a commit to zed-extensions/vue that referenced this issue Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors vue Vue.js framework support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants