Properly pass nested script arguments for tasks #10776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making the shell to substitute Zed variables itself. Zed still does the resolution on its side to display the labels in the UI. co-authored-by: Piotr Osiewicz <piotr@zed.dev>
cla-bot
bot
added
the
cla-signed
SomeoneToIgnore
force-pushed
the
kb/better-task-escapes
branch
from
38f56f4
to
e9a77d3
Compare
SomeoneToIgnore
added a commit
that referenced
this pull request
Apr 19, 2024
Closes #10732 (comment) introduced by #10548 while keeping both Python and Bash run selection capabilities. Also replaced redundant `SpawnTask` struct with `SpawnInTerminal` that has identical fields. Release Notes: - Fixed incorrect task escaping of nested script arguments --------- Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10732 (comment) introduced by #10548 while keeping both Python and Bash run selection capabilities.
Also replaced redundant
SpawnTaskstruct withSpawnInTerminalthat has identical fields.Release Notes: