Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file finder match results #12103

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented May 21, 2024

Fixes #11970
Fixes #11965

Reworks file file_finder::Toggle command to have a separate_history (default false) parameter.
The new default does not prioritize history items, sorting them and search results by score — this mode also turns off the history items separator (as those are now mixed with the search results).
Old behavior can be restored by rebinding to ["file_finder::Toggle", { "separate_history": true }].

Also adds a more visible indication of the item being a history one, same as in the tasks modal.

Before:
Screenshot 2024-05-21 at 23 53 10

After ("separate_history": false):
Screenshot 2024-05-21 at 23 52 18

Alternative ("separate_history": true):
Screenshot 2024-05-21 at 23 52 45

Release Notes:

  • Improved file finder search sorting (11970)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 21, 2024
@SomeoneToIgnore SomeoneToIgnore merged commit 3382e79 into main May 22, 2024
8 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/file-finder-ergonomics branch May 22, 2024 04:35
SomeoneToIgnore added a commit that referenced this pull request May 22, 2024
Small follow-ups for #12063
and #12103

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to File sort order priority Fuzzy finder sometimes has strange ordering
1 participant