-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json: Add runnable for package.json
and composer.json
scripts
#12285
json: Add runnable for package.json
and composer.json
scripts
#12285
Conversation
To change runner from npm to yarn, for example. Do I have to copy task and replace npm run with yarn, or is it possible, to configure runner somehow? |
@RemcoSmitsDev , @znycheporuk : The question is whether I need to use |
Before if you would open the task modal you would see a task for `scripts` which is incorrect, because you cannot run it. So changing it to a custom variable fixes this.
See the following comment on my JavaScript runnable PR #12118 (comment). We want to make something like that, but I'm not sure if we want to merge this and first just let people duplicate the task if they want to use a different runner or make it more user-friendly first. |
@osiewicz It might be cool to be able to specify a filename pattern that the task is allowed to show up. This way, we could separate |
This allows us to use the same query for `package.json` and `composer.json`
package.json
scriptspackage.json
and composer.json
scripts
@RemcoSmitsDev, I agree that it would be cool to specify env variables for tasks like this
In my opinion if adding this functionality will take an additional week or two, it's probably better to wait until it can be implemented in a more general way. However, if there's no clear timeline for when it will be possible to use such variables in tasks, then merge the PR as it is and update the task later. |
I'm out in the latter half of the next week, so I'd rather have us start with something (even if it's not ideal) and then refine it once user-provided task variables do land. |
I think that would be feasible to do, yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Should be good to go now! |
Package.json
Screen.Recording.2024-05-25.at.17.42.48.mov
Composer.json
Screen.Recording.2024-05-26.at.12.27.09.mov
Release Notes:
package.json
andcomposer.json
scripts (#12215).